Removed unreachable code

[sreichel]

Description

Removed return statements that are never reached.

Fixed Issues (if relevant)

1. none

Manual testing scenarios

1. none

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @sreichel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[aleron75]

Some static tests fails because with your refactoring the method parameter $attribute is not used any more.
Please, add a @SuppressWarnings(PHPMD.UnusedFormalParameter) directive in method's docblock to avoid the static test to fail.

[aleron75]

Some static tests fails because with your refactoring the method parameter $id is not used any more.
Please, add a @SuppressWarnings(PHPMD.UnusedFormalParameter) directive in method's docblock to avoid the static test to fail.

[sreichel]

Thanks. Fixed it.

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-2661 has been created to process this Pull Request

[magento-engcom-team]

@sreichel thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @sreichel. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.