Skip to content

Conversation

@swnsma
Copy link
Contributor

@swnsma swnsma commented Jul 28, 2018

Description

  • add unit test coverage for \Magento\Catalog\CustomerData\CompareProducts class;
  • add missed property '$outputHelper' declaration;

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

al.kravchuk added 2 commits July 28, 2018 23:23
- add missed property;
- add variable annotation;
- add unit test coverage.
@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jul 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@swnsma swnsma changed the title Maintenance: Compare products. Add unit test coverage & missed class property declaraion. Maintenance: Compare products. Add unit test coverage & missed class property declaration. Jul 28, 2018
@miguelbalparda miguelbalparda self-assigned this Jul 30, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2632 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 8019ccb into magento:2.2-develop Aug 7, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @swnsma. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants