Skip to content

[Backport] Remove commented code #17237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2018
Merged

[Backport] Remove commented code #17237

merged 1 commit into from
Jul 29, 2018

Conversation

tiagosampaio
Copy link
Member

Original Pull Request

#17077

Description

Remove commented code from files.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mageprince mageprince self-assigned this Jul 28, 2018
@mageprince mageprince self-requested a review July 28, 2018 16:48
@ihor-sviziev ihor-sviziev self-assigned this Jul 28, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2571 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit ebe636d into magento:2.1-develop Jul 29, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 29, 2018
ENGCOM-2571: [Backport] Remove commented code #17237
3daf3f0
@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

@tiagosampaio tiagosampaio deleted the 2.1-develop-PR-port-17077 branch August 7, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@mageprince mageprince mageprince approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@mageprince mageprince

Labels
Cleanup Component: Framework/Data Component: Framework/Model Component: Review Component: Sales Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
5 participants
@tiagosampaio @magento-engcom-team @ihor-sviziev @mageprince @mage2pratik