Skip to content

[Backport] Added unit test for DB model in backup module #17214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Backport] Added unit test for DB model in backup module #17214

wants to merge 1 commit into from

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#17063

Description

This PR adds a missing unit test for \Magento\Backup\Model\Db model.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@ihor-sviziev ihor-sviziev mentioned this pull request Jul 28, 2018
Closed
@ihor-sviziev ihor-sviziev self-assigned this Jul 28, 2018
@ihor-sviziev
Copy link
Contributor

Hi @mage2pratik,
Unit tests are fails because older phpunit version in 2.1.x line. Could you update test to be compliant with 2.1.x?

@sidolov
Copy link
Contributor

sidolov commented Aug 13, 2018

Hi @mage2pratik , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ihor-sviziev ihor-sviziev

Labels
Component: Backup Progress: needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mage2pratik @ihor-sviziev @sidolov @magento-engcom-team @rogyar