-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forwardport] Refactory to Magento_Backend module class. #17102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] Refactory to Magento_Backend module class. #17102
Conversation
|
Hi @tiagosampaio. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
FYI It's better to create up ports just after your PR was merged because original PR might contains some additional fixes and you have to add them. Also forward ports might be easy created by special tool (only when original PR was merged): https://github.com/magento/magento2/wiki/Simple-way-to-port-your-solutions-automatically |
|
Hi @tiagosampaio, |
Revert backward incompatible changes
|
Hi @ihor-sviziev. I had to cherry-pick the commit a1339ba before yours. That should be fine now. Thanks. |
|
@tiagosampaio thx, will review this PR just when original PR will be merged |
|
Hi @ihor-sviziev, thank you for the review. |
|
Hi @tiagosampaio. Thank you for your contribution. |
Refactory of a class in Magento_Backend module.
Description
Simple refactory to Magento_Backend module class.
Contribution checklist
Original PR:
#17101