Skip to content

[Backport] testGetIgnoresFirstSlash method in ObjectManagerTest has lost its purpose (dummy test) #17098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Conversation

mageprince
Copy link
Contributor

@mageprince mageprince commented Jul 24, 2018

Original Pull Request

#11666

Once upon a time, long long time ago, in the beginning of times, there was a test method inside a unit test class with a purpose. Nowadays, it has become a dummy test, because of some refactoring.

\Magento\Framework\ObjectManager\Test\Unit\ObjectManagerTest::testGetIgnoresFirstSlash is that method, intended to check if same object was returned when calling ObjectManager::get('\Classname') and ObjectManager::get('Classname'):
captura de pantalla 2017-10-24 a las 1 28 39

Now, it really doesn't check anything, because the two calls are the same:
captura de pantalla 2017-10-24 a las 1 23 35

Description

Proposed change will make this test useful again, as when it was born:
captura de pantalla 2017-10-24 a las 1 41 59

Fixed Issues (if relevant)

None.

Manual testing scenarios

  1. Run unit tests over this class.
  2. They should pass with the changes.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@mageprince mageprince deleted the 2.2-develop-PR-port-11666 branch July 27, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants