Skip to content

Remove commented code #17077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Remove commented code #17077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/code/Magento/Review/Model/ResourceModel/Rating/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ public function setStoreFilter($storeId)
'main_table.rating_id = store.rating_id',
[]
);
// ->group('main_table.rating_id')
$this->_isStoreJoined = true;
}
$inCondition = $connection->prepareSqlCondition('store.store_id', ['in' => $storeId]);
Expand Down
7 changes: 0 additions & 7 deletions app/code/Magento/Sales/Model/Order/Creditmemo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,13 +471,6 @@ public function getStateName($stateId = null)
*/
public function setShippingAmount($amount)
{
// base shipping amount calculated in total model
// $amount = $this->getStore()->round($amount);
// $this->setData('base_shipping_amount', $amount);
//
// $amount = $this->getStore()->round(
// $amount*$this->getOrder()->getStoreToOrderRate()
// );
return $this->setData(CreditmemoInterface::SHIPPING_AMOUNT, $amount);
}

Expand Down
8 changes: 0 additions & 8 deletions lib/internal/Magento/Framework/Data/Form/Element/Checkboxes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,14 +178,6 @@ public function getOnchange($value)
return;
}

// public function getName($value)
// {
// if ($name = $this->getData('name')) {
// return str_replace('$value', $value, $name);
// }
// return ;
// }

/**
* @param array $option
* @return string
Expand Down
3 changes: 0 additions & 3 deletions lib/internal/Magento/Framework/Model/ResourceModel/Db/Relation/ActionPool.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ public function getActions($entityType, $actionName)
}
foreach ($this->relationActions[$entityType][$actionName] as $actionClassName) {
$action = $this->objectManager->get($actionClassName);
//if (!$action instanceof ProcessEntityRelationInterface) {
// throw new \Exception('Not compliant with action interface');
//}
$actions[] = $action;
}
return $actions;
Expand Down