Skip to content

[Backport] Remove unused comments from _initDiscount() function #17003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2018
Merged

[Backport] Remove unused comments from _initDiscount() function #17003

merged 3 commits into from
Jul 23, 2018

Conversation

@mageprince
Copy link
Contributor

@mageprince mageprince commented Jul 22, 2018

Original Pull Request

#16875

Description

Remove unused comments from _initDiscount() function of Tax.php

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Jul 22, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 22, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 22, 2018

Hi @orlangur, thank you for the review.
ENGCOM-2460 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit a40f06b into magento:2.1-develop Jul 23, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2018
ENGCOM-2460: [Backport] Remove unused comments from _initDiscount() f…
1802656 
…unction #17003
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 23, 2018

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

@mageprince mageprince deleted the 2.1-develop-PR-port-16875 branch July 24, 2018 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels

Cleanup Component: Tax Progress: accept Release Line: 2.1

Projects

None yet

Milestone

Release: 2.1.15

Development

Successfully merging this pull request may close these issues.

4 participants

@mageprince @magento-engcom-team @orlangur @pprincepatel