Issue 8131 - Use Redirect Factory to Allow Error Message Display on Advanced Search

[brobie]

Change controller to use result redirect factory which fixes error message display on advanced search form.

#8131

Description

The way the redirect was initiated from the result controller needed to be changed to use a result redirect so that the error message would be written to the cookie. Without this, the Index controller wouldn't be called when Page Cache was enabled, and the error message would never reach the page.

Fixed Issues (if relevant)

1. Magento 2.1.3 - There is a bug in advanced search form regarding validation messages #8131: Magento 2.1.3 - There is a bug in advanced search form regarding validation messages

Manual testing scenarios

1. Navigate to Advanced Search
2. Without filling out any form input field, click "Search"
3. You should see the error message requiring you to fill in at least one form.

This should work when page cache is enabled and disabled.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @brobie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[ihor-sviziev]

I think it will be good idea to check if method returned $responseMock

[brobie]

@ihor-sviziev - Done, pushed, and pending automated testing.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2455 has been created to process this Pull Request

[magento-engcom-team]

@brobie thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @brobie. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.