Skip to content

Conversation

@jochhop
Copy link
Contributor

@jochhop jochhop commented Jul 19, 2018

Removed unused interface reference

Description

The interface Magento\Framework\Indexer\StateInterface is not being used in this class, so its reference declaration is not necessary

Fixed Issues (if relevant)

Improvement

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: SNOW.DOG Pull Request is created by partner SNOW.DOG partners-contribution Pull Request is created by Magento Partner labels Jul 19, 2018
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 19, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @jochhop. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@osrecio
Copy link
Member

osrecio commented Jul 19, 2018

Hi @jochhop , Thanks for your contribution.

Can you edit your Comment following the PR Template ? Will it useful for us to process the PR. (I know that is a small PR, but it's necessary)

@jochhop
Copy link
Contributor Author

jochhop commented Jul 19, 2018

Hi @osrecio , thanks for the clarification, I have updated it, is it enough?

@osrecio
Copy link
Member

osrecio commented Jul 19, 2018

I edited the comment with correct format.

Thanks

@magento-engcom-team
Copy link
Contributor

Hi @jochhop. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@jochhop jochhop deleted the remove-unused-interface branch July 20, 2018 12:32
@orlangur
Copy link
Contributor

@jochhop @osrecio please pay attention that such manual change is not really needed as can be done with php-cs-fixer all over the code automatically and will be done in near future.

@osrecio
Copy link
Member

osrecio commented Jul 22, 2018

@orlangur I did in my PR for lib/internal/magento #16946 with php-cs-fixer :)

@jochhop
Copy link
Contributor Author

jochhop commented Jul 23, 2018

thanks @orlangur I'll use it the next time for this kind of issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Component: Customer Partner: SNOW.DOG Pull Request is created by partner SNOW.DOG partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants