[Forwardport] Fixed type hints and docs for Downloadable Samples block

[ronak2ram]

Original Pull Request

#16408

Summary

Fixes type hints and PHPDocs in Magento\Downloadable\Block\Catalog\Product\Samples.

Description

In the block class unprecise type hints and PHPDocs are provided. Instead of Magento\Downloadable\Model\ResourceModel\Sample the method getSampleUrl gets an object of type Magento\Downloadable\Model\Sample which actually should be considered as Magento\Downloadable\Api\Data\SampleInterface. Also getSamples doesn't return an array, it returns a Collection.

Fixed Issues

This pull request is not fixing a bug, it just to improve type hints in IDE.

[magento-engcom-team]

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @ronak2ram. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.