Replace sort callbacks to spaceship operator

[lbajsarowicz]

Description

Small change to improve overall readability of Shipping Methods sorting

Manual testing scenarios

1. Add multiple shipping methods with different Sort Orders
2. Proceed to checkout, compare shipping methods with expected ones

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[orlangur]

Nice finding @lbajsarowicz! 👍

[lbajsarowicz]

I've found 3 more, to have it replaced globally.

[orlangur]

@lbajsarowicz big thanks for not making it as 4 separate PRs 👍

[lbajsarowicz]

Do I have to do anything to get this merged.
@orlangur

[orlangur]

@lbajsarowicz no, you don't AFAIK.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-2613 has been created to process this Pull Request

[magento-engcom-team]

Hi @lbajsarowicz. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.