Skip to content

Fix Translation of error message on cart for deleted bundle option. #16777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Fix Translation of error message on cart for deleted bundle option. #16777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7e31c0
magento/magento2#?: Fix Translation of error message on cart for dele…
Jul 13, 2018
5f4e6d3
magento/magento2#?: Fix Translation of error message on cart for dele…
Jul 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Multishipping/etc/frontend/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@
<plugin name="multishipping_session_mapper" type="Magento\Multishipping\Model\Checkout\Type\Multishipping\Plugin" sortOrder="50" />
</type>
<type name="Magento\Checkout\Controller\Cart">
<plugin name="multishipping_clear_addresses" type="Magento\Multishipping\Model\Cart\Controller\CartPlugin" />
<plugin name="multishipping_clear_addresses" type="Magento\Multishipping\Model\Cart\Controller\CartPlugin" sortOrder="50" />
Copy link
Contributor

@orlangur orlangur Jul 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swnsma, looks pretty unreliable to me. Can you describe what is going on and maybe we will try to elaborate a robust fix together?

Copy link
Contributor Author

@swnsma swnsma Jul 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @orlangur !
In two words, Inline Translate Phrase renderer loads later than error message Phrase become rendered.

The error message source.

magento2/app/code/Magento/Bundle/Model/Product/Type.php

Line 1106 in 07bd6e5

__('The required options you selected are not available.')

error message source trace

Rendered become loaded deep in Magento\Framework\App\Action\Plugin\Design plugin call.
The plugin has sort order 30.

magento2/app/code/Magento/Store/etc/di.xml

Line 68 in 07bd6e5

<plugin name="designLoader" type="Magento\Framework\App\Action\Plugin\Design" sortOrder="30"/>

renderer load trace

As alternative, sort order for this plugin could be set to 0, to prevent possible issue in future.

</type>
</config>
2 changes: 1 addition & 1 deletion app/code/Magento/Store/etc/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
<preference for="Magento\Framework\App\Router\PathConfigInterface" type="Magento\Store\Model\PathConfig" />
<type name="Magento\Framework\App\Action\AbstractAction">
<plugin name="storeCheck" type="Magento\Store\App\Action\Plugin\StoreCheck" sortOrder="10"/>
<plugin name="designLoader" type="Magento\Framework\App\Action\Plugin\Design" sortOrder="30"/>
<plugin name="designLoader" type="Magento\Framework\App\Action\Plugin\Design" />
</type>
<type name="Magento\Framework\Url\SecurityInfo">
<plugin name="storeUrlSecurityInfo" type="Magento\Store\Url\Plugin\SecurityInfo"/>
Expand Down