Skip to content

Conversation

@hitesh-wagento
Copy link
Contributor

Original Pull Request

#12045

Description

Change less styles for field-control so datepicker fields do not appear out of place

Fixed Issues (if relevant)

  1. Datepicker does not scroll #7903: Datepicker does not scroll

Manual testing scenarios

As described in the issue

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Jul 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@hitesh-wagento
Copy link
Contributor Author

@sidolov

Any update in this PR ?

Thanks

@sidolov
Copy link
Contributor

sidolov commented Jul 17, 2018

Hi @hitesh-wagento , your PR currently in delivery process

@hitesh-wagento hitesh-wagento requested a review from sidolov July 23, 2018 11:10
@hitesh-wagento
Copy link
Contributor Author

@magento-engcom-team

Any update in this PR ?

Thanks

@hitesh-wagento
Copy link
Contributor Author

@sidolov

Any update in this PR ?

Thanks

@hitesh-wagento
Copy link
Contributor Author

hitesh-wagento commented Sep 11, 2018

Hi @sidolov

This pull request Merging In Progress thenafter again in TODO list. can you please let me know is there any issues ?

Thanks

image

@magento-engcom-team magento-engcom-team merged commit 7180790 into magento:2.2-develop Sep 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants