Add sort order to user agent rules table headers

[JRhyne]

Summary / Description

Only one column on the User Agent Rules table had a sort order. This was causing the content of the table rows to not match the content of the table. I added the sortOrder attribute on the other two columns and this fixed the issue.

Fixed Issues (if relevant)

1. User Agent Rules table headers do match content of rows. #16703 : User Agent Rules table headers do match content of rows

Manual testing scenarios

1. Visit the page where you can edit a design configuration (change the theme). And review the table's headers.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @JRhyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

@JRhyne are you referring to

<actionDelete template="Magento_Backend/dynamic-rows/cells/action-delete" sortOrder="50">

? Can we simply remove its sortOrder to achieve the same?

[JRhyne]

Yes, that solution will work as well. I added sortOrder to the other fields to support adding columns in specific order to that table.

Should I resubmit the request?

[orlangur]

Please do a commit amend and force push into the same branch.

As sortOrder is not mandatory, I'm quite sure we can omit it. Probably sortOrder for these fields may be declared in your theme and then merged altogether.

[JRhyne]

Alright, it's pushed.

Sounds good.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-2263 has been created to process this Pull Request

[magento-engcom-team]

@JRhyne thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @JRhyne. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.