Skip to content

Added 'title' attribute to 'a' link. #16689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2018
Merged

Added 'title' attribute to 'a' link. #16689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
196356d
Added 'title' attribute to 'a' link.
sanganinamrata Jul 10, 2018
28ec673
Added 'title' attribute to 'img' tag.
sanganinamrata Jul 10, 2018
092c4fc
Added 'title' attribute to 'img' tag.
sanganinamrata Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/view/adminhtml/templates/page/header.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<?= /* @escapeNotVerified */ $edition ?>
class="logo">
<img class="logo-img" src="<?= /* @escapeNotVerified */ $block->getViewFileUrl($logoSrc) ?>"
alt="<?= $block->escapeHtml(__('Magento Admin Panel')) ?>"/>
alt="<?= $block->escapeHtml(__('Magento Admin Panel')) ?>" title="<?= $block->escapeHtml(__('Magento Admin Panel')) ?>"/>
</a>
<?php break; ?>
<?php case 'user': ?>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/view/adminhtml/templates/widget/form/element/gallery.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<?php foreach ($block->getValues()->getAttributeBackend()->getImageTypes() as $type): ?>
<td class="gallery" align="center" style="vertical-align:bottom;">
<a href="<?= /* @escapeNotVerified */ $image->setType($type)->getSourceUrl() ?>" target="_blank" onclick="imagePreview('<?= $block->getElement()->getHtmlId() ?>_image_<?= /* @escapeNotVerified */ $type ?>_<?= /* @escapeNotVerified */ $image->getValueId() ?>');return false;">
<img id="<?= $block->getElement()->getHtmlId() ?>_image_<?= /* @escapeNotVerified */ $type ?>_<?= /* @escapeNotVerified */ $image->getValueId() ?>" src="<?= /* @escapeNotVerified */ $image->setType($type)->getSourceUrl() ?>?<?= /* @escapeNotVerified */ time() ?>" alt="<?= /* @escapeNotVerified */ $image->getValue() ?>" height="25" class="small-image-preview v-middle"/></a><br/>
<img id="<?= $block->getElement()->getHtmlId() ?>_image_<?= /* @escapeNotVerified */ $type ?>_<?= /* @escapeNotVerified */ $image->getValueId() ?>" src="<?= /* @escapeNotVerified */ $image->setType($type)->getSourceUrl() ?>?<?= /* @escapeNotVerified */ time() ?>" alt="<?= /* @escapeNotVerified */ $image->getValue() ?>" title="<?= /* @escapeNotVerified */ $image->getValue() ?>" height="25" class="small-image-preview v-middle"/></a><br/>
<input type="file" name="<?= /* @escapeNotVerified */ $block->getElement()->getName() ?>_<?= /* @escapeNotVerified */ $type ?>[<?= /* @escapeNotVerified */ $image->getValueId() ?>]" size="1"></td>
<?php endforeach; ?>
<td class="gallery" align="center" style="vertical-align:bottom;"><input type="input" name="<?= /* @escapeNotVerified */ $block->getElement()->getParentName() ?>[position][<?= /* @escapeNotVerified */ $image->getValueId() ?>]" value="<?= /* @escapeNotVerified */ $image->getPosition() ?>" id="<?= $block->getElement()->getHtmlId() ?>_position_<?= /* @escapeNotVerified */ $image->getValueId() ?>" size="3"/></td>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Theme/view/frontend/templates/html/bugreport.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<small class="bugs">
<span><?= /* @escapeNotVerified */ __('Help Us Keep Magento Healthy') ?></span>
<a href="http://www.magentocommerce.com/bug-tracking"
target="_blank">
target="_blank" title="<?= /* @escapeNotVerified */ __('Report All Bugs') ?>">
<?= /* @escapeNotVerified */ __('Report All Bugs') ?>
</a>
</small>
1 change: 1 addition & 0 deletions app/code/Magento/Theme/view/frontend/templates/html/header/logo.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<a class="logo" href="<?= $block->getUrl('') ?>" title="<?= /* @escapeNotVerified */ $storeName ?>">
<?php endif ?>
<img src="<?= /* @escapeNotVerified */ $block->getLogoSrc() ?>"
title="<?= /* @escapeNotVerified */ $block->getLogoAlt() ?>"
alt="<?= /* @escapeNotVerified */ $block->getLogoAlt() ?>"
<?= $block->getLogoWidth() ? 'width="' . $block->getLogoWidth() . '"' : '' ?>
<?= $block->getLogoHeight() ? 'height="' . $block->getLogoHeight() . '"' : '' ?>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Ui/view/base/web/templates/block-loader.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
-->
<div data-role="loader" class="loading-mask" style="position: absolute;">
<div class="loader">
<img src="<%= loaderImageHref %>" alt="Loading..." style="position: absolute;">
<img src="<%= loaderImageHref %>" alt="Loading..." title="Loading..." style="position: absolute;">
</div>
</div>