Skip to content

Conversation

@AnshuMishra17
Copy link
Contributor

Description

Refactor the code by removing the direct use of ObjectManager and includes the dependencies using Constructor Dependency Injection

Manual testing scenarios

  1. Created, updated and deleted checkout agreements from the admin-end.

@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda miguelbalparda self-assigned this Jul 4, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2210 has been created to process this Pull Request

/**
* @var CheckoutAgreementsRepositoryInterface
*/
protected $_agreementRepository;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, inject dependencies in classes when they are really needed.
Make new properties private and try to avoid usage leading underscore in var and methods name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2210 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants