Skip to content

Conversation

@gelanivishal
Copy link
Contributor

Original Pull Request

#15521

Description

Move breadcrumb json configuration to viewmodel and serialize it using Magento json serializer
Tweak code motivated by a discussion in pull request #15162

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@gelanivishal gelanivishal changed the title Move breadcrumb json configuration to viewmodel [Forwardport] Move breadcrumb json configuration to viewmodel Jun 30, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 30, 2018
@VladimirZaets
Copy link
Contributor

Hi, @gelanivishal, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants