Skip to content

Conversation

@tiagosampaio
Copy link
Member

@tiagosampaio tiagosampaio commented Jun 26, 2018

Replacing the method proccessAdditionalValidation by processAdditionalValidation. It's was mistype error.

Description

Fixed a mistype error in a method name.

Fixed Issues (if relevant)

None.

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#16414

 - Replacing the method proccessAdditionalValidation by processAdditionalValidation. It's was mistype error.
@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes must be applied to 2.2-develop first.

@tiagosampaio
Copy link
Member Author

@orlangur the same pull request was applied to branch 2.2-develop and it's already merged. Please check the pull request in #16414.

@orlangur orlangur changed the title Fixing a Mistype Error [Forwardport] Fixing a Mistype Error Jul 13, 2018
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagosampaio true, thanks for pinging!

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2338 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@tiagosampaio tiagosampaio deleted the hotfix/2.3-develop-16411 branch August 7, 2018 12:58
@tiagosampaio tiagosampaio restored the hotfix/2.3-develop-16411 branch October 18, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants