Skip to content

Conversation

0m3r
Copy link
Contributor

@0m3r 0m3r commented Jun 18, 2018

Description

The shipping and estimate tax form doesn't display the form with country, city, postcode fields.
The form is in the dom, but hidden.

jquery.storageapi.min.js:2 Uncaught TypeError: Cannot read property 'htmlblock-shipping' of null

Fixed Issues

  1. Estimate Shipping and Tax Form not works due to js error in collapsible.js [proposed fix] #8222: Estimate Shipping and Tax Form not works due to js error in collapsible.js

Manual testing scenarios

  1. Open chrome dev console
  2. run: './././'.replace('.', '')
  3. run: './././'.replace(/./g,'')
  4. profit

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @0m3r. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 18, 2018

CLA assistant check
All committers have signed the CLA.

@VladimirZaets
Copy link
Contributor

Hi @0m3r, please, sign CLA, otherwise, we can't process your pull request

@magento-engcom-team
Copy link
Contributor

@0m3r thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @0m3r. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@0m3r 0m3r mentioned this pull request Jun 28, 2018
4 tasks
@gelanivishal gelanivishal mentioned this pull request Jul 3, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants