Skip to content

Conversation

@hitesh-wagento
Copy link
Contributor

Original Pull Request

#15811

This PR is a:

  • Bug fix or improvement

Summary

Correct Code formatting.

Additional information

NA

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

Hi @hitesh-wagento,
You have commits without commit message. Could you fix it and force push this PR?

@hitesh-wagento
Copy link
Contributor Author

Hi @ihor-sviziev

I have created Forwardport using port tool. how can I add commit message in it ?

Thanks

@orlangur orlangur self-assigned this Jun 15, 2018
@ishakhsuvarov
Copy link
Contributor

@hitesh-wagento You may checkout out this branch locally and do a reword for the commit messages.
Here is a reference on the process: https://help.github.com/articles/changing-a-commit-message/

@hitesh-wagento hitesh-wagento force-pushed the 2.3-develop-PR-port-15811 branch from b651610 to 09e01a4 Compare June 15, 2018 09:08
@hitesh-wagento
Copy link
Contributor Author

hitesh-wagento commented Jun 15, 2018

Hi @ishakhsuvarov

I have force pushed my commit. Why this showing conflicts ? Why this showing conflicts ?

@ishakhsuvarov
Copy link
Contributor

@hitesh-wagento Looks like you had some errors with the rebase process. Also, commits with empty messages are still present. Please verify your procedure and try again.

@hitesh-wagento
Copy link
Contributor Author

hitesh-wagento commented Jun 15, 2018

Hi @ishakhsuvarov

I have run follow commands :
git commit --amend
git push --force

image

I have created Forwardport using Port tool. Can I create again ?

@orlangur
Copy link
Contributor

@hitesh-wagento it looks like you are doing something very wrong, merge commits cannot appear by themselves.

@hitesh-wagento
Copy link
Contributor Author

hitesh-wagento commented Jun 15, 2018

Hi @orlangur

As per your yesterday's suggestion I have created Forwardport using Port tool #15813 (comment). I didn't do any manually changes.

@orlangur
Copy link
Contributor

@hitesh-wagento this PR was initially consisting of four commits with empty messages. Now I see a lot of merge commits. So, obviously something is going on on your side.

@hitesh-wagento
Copy link
Contributor Author

Hi @orlangur

Can I create again new PR with port tool ?

@orlangur
Copy link
Contributor

@hitesh-wagento surely.

@hitesh-wagento hitesh-wagento force-pushed the 2.3-develop-PR-port-15811 branch from bc2a8ba to f98a132 Compare June 18, 2018 08:49
@hitesh-wagento
Copy link
Contributor Author

Hi @orlangur

I have created again Pull request using port tool but it's showing me 39 Files changes.

Can you please check once : hitesh-wagento#19

Thanks

@orlangur
Copy link
Contributor

@hitesh-wagento I believe you are not supposed to create porting PR in your own fork. As you see other changes from origin 2.3-develop are appearing in your fork PR as a result.

@hitesh-wagento hitesh-wagento force-pushed the 2.3-develop-PR-port-15811 branch 2 times, most recently from 485e9cb to 5958df0 Compare June 20, 2018 08:46
@hitesh-wagento hitesh-wagento force-pushed the 2.3-develop-PR-port-15811 branch from ead444c to b854d2c Compare June 20, 2018 08:55
@hitesh-wagento hitesh-wagento deleted the 2.3-develop-PR-port-15811 branch September 6, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: needs update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants