-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forwardport] [Correct code formatting] #16147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] [Correct code formatting] #16147
Conversation
|
Hi @hitesh-wagento. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @hitesh-wagento, |
|
I have created Forwardport using port tool. how can I add commit message in it ? Thanks |
|
@hitesh-wagento You may checkout out this branch locally and do a reword for the commit messages. |
b651610 to
09e01a4
Compare
|
I have force pushed my commit. Why this showing conflicts ? Why this showing conflicts ? |
|
@hitesh-wagento Looks like you had some errors with the rebase process. Also, commits with empty messages are still present. Please verify your procedure and try again. |
|
I have run follow commands : I have created Forwardport using Port tool. Can I create again ? |
|
@hitesh-wagento it looks like you are doing something very wrong, merge commits cannot appear by themselves. |
|
Hi @orlangur As per your yesterday's suggestion I have created Forwardport using Port tool #15813 (comment). I didn't do any manually changes. |
|
@hitesh-wagento this PR was initially consisting of four commits with empty messages. Now I see a lot of merge commits. So, obviously something is going on on your side. |
|
Hi @orlangur Can I create again new PR with port tool ? |
|
@hitesh-wagento surely. |
bc2a8ba to
f98a132
Compare
|
Hi @orlangur I have created again Pull request using port tool but it's showing me 39 Files changes. Can you please check once : hitesh-wagento#19 Thanks |
|
@hitesh-wagento I believe you are not supposed to create porting PR in your own fork. As you see other changes from origin |
485e9cb to
5958df0
Compare
ead444c to
b854d2c
Compare

Original Pull Request
#15811
This PR is a:
Summary
Correct Code formatting.
Additional information
NA