Skip to content

[Forwardport] Disabling sorting in glob and scandir functions for better performance #16126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Forwardport] Disabling sorting in glob and scandir functions for better performance #16126

wants to merge 1 commit into from

Conversation

@chirag-wagento
Copy link
Contributor

@chirag-wagento chirag-wagento commented Jun 14, 2018

Original Pull Request

#16052
Disabling sorting in glob and scandir functions for better performance

Description

Disabling sorting in glob and scandir functions for better performance

https://www.exakat.io/php-likes-sorting/

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 14, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 14, 2018

Hi @chirag-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@osrecio
Copy link
Member

osrecio commented Jun 14, 2018

Rejected this PR giving priority to the original author: #16128

@osrecio osrecio self-assigned this Jun 14, 2018
@osrecio osrecio closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@osrecio osrecio

Labels

Component: Framework/App Component: Framework/Archive Component: Framework/Backup Component: Framework/Data Component: Framework/Filesystem Component: Framework/Validator Component: Setup Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chirag-wagento @magento-engcom-team @osrecio