-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Replaced @escapeNotVerified annotations #16091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @istiahailo. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea to escape translations, like __('SKU').
|
@orlangur, translations also should be escaped. It's possible when translation would contain HTML tags for different languages. You can't guarantee that, for example, a French (or any other) translation for |
|
@istiahailo thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Hi @istiahailo. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
|
The "Porting tool" can't port commits automatically to 2.3 release line.These commits need the manual porting. |
Description
There were added the escape functions to prevent XSS issues.
Contribution checklist