Skip to content

Conversation

chirag-wagento
Copy link
Contributor

Original Pull Request

#16001

Description

Default FormElementDependenceController config should be extended by custom config but not overridden.

Manual testing scenarios

  1. Add custom options to FormElementDependenceController config;
  2. Open System config page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Contributor

Hi, @chirag-wagento, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Lib/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants