Skip to content

fix for dropdown toggle icon in cart #15991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2018
Merged

fix for dropdown toggle icon in cart #15991

merged 1 commit into from
Jun 13, 2018

Conversation

@Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Jun 11, 2018

Description

Fixed cart page sidebar dropdown icon symbol.

Manual testing scenarios

  1. Open cart page. Toggle discount or Tax dropdown.
    Expected: arrow down changes to arrow up.
    Currently: arrow down changes to arrow left.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 11, 2018
This was referenced Jun 12, 2018
Merged
Merged
@orlangur orlangur self-assigned this Jun 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1941 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit bfa4bf5 into magento:2.2-develop Jun 13, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 13, 2018
@VladimirZaets
ENGCOM-1941: fix for dropdown toggle icon in cart #15991
b778d5f
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@Karlasa Karlasa deleted the icon-fix branch June 16, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@VladimirZaets VladimirZaets

Labels

Area: Design/Frontend Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.6

Development

Successfully merging this pull request may close these issues.

4 participants

@Karlasa @magento-engcom-team @orlangur @VladimirZaets