[Forwardport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s… #8

[chirag-wagento]

Original Pull Request

#15010
reopen #13446

…et to 0 for new products when using index on save

Description

If you use the \Magento\Framework\Api\SearchCriteriaBuilder and the flat product row_id is set to 0. The product isn't shown in the getList of the ProductRepository

Manual testing scenarios

Issue was in the Commerce (EE) version but can be solved in the Open Source Codebase

1. Enable Product Flat Catalog Stores > Settings > Configuration > Catalog > Catalog > Storefront > Use Flat Catalog Product
2. Run the index manually through the command line php bin/magento indexer:reindex catalog_product_flat
3. Set the Indexes to On Save System > Tools > Index Management > Select all and select the action Update on Save
4. Create a New Product with SKU test
5. Take a look in the database in the catalog_product_flat_1 tabel and search for the product with SKU test
6. The row_id will be set to 0
7. Apply Changes
8. Save the Product
9. Take a look at the database in the catalog_product_flat_1 tabel and search for the product with SKU test
10. The row_id should now be equal to the entity_id

Besides looking in the database you could create a simpel collection by using the SearchCritieria and the ProductRepository

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[chirag-wagento]

@lewisvoncken Could you please check what cause failed travis?

Thanks,

[orlangur]

@chirag-wagento please fix failed tests.

[chirag-wagento]

@orlangur I can see Connection time out error in travis.
So Could you please check failed travis once again?

Thanks

[chirag-wagento]

@orlangur

Any update in this PR?

Thanks

[chirag-wagento]

@orlangur can you give me failed travis update?

Thanks

[orlangur]

@chirag-wagento restarted build.

[chirag-wagento]

@orlangur I can see Connection time out error in travis.
So Could you please check failed travis once again?

Thanks

[orlangur]

@chirag-wagento Travis CI timeouts are not fixable by rerun.

Changes approved.

[chirag-wagento]

Hi @orlangur

Any update in this PR?

Thanks

[chirag-wagento]

Hello @orlangur

Any update in this PR?

Thanks

[chirag-wagento]

Hi @orlangur

[sidolov]

Hi @chirag-wagento , looks like your repository or branch was removed. I'm closing this PR, please, create the new one if you wish to continue.