Skip to content

Conversation

@RahulKachhadia
Copy link
Contributor

Original Pull Request

#15269

Description

Fixes a typo in the \Magento\Framework\Image::open exception message.

Previous message:

File {file} does not exists.

Corrected message:

File {file} does not exist.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. Given that...
  • There exists a page where an image is opened,
  • but the actual image file does not exist,
  • and the exception is not silently caught and ignored,
  1. Expect to receive a properly-spelled exception message.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jun 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1843 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rahul-kachhadiya. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

@RahulKachhadia RahulKachhadia deleted the 2.1-develop-PR-port-15269 branch June 5, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants