Skip to content

Move breadcrumb json configuration to viewmodel #15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2018
Merged

Move breadcrumb json configuration to viewmodel #15521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
213e11d
Move breadcrumb json configuration to viewmodel
diedburn May 25, 2018
603de52
Added escape text.
gelanivishal May 28, 2018
e95f3f7
Make new Json dependency backwards compatible
tdgroot Jun 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion app/code/Magento/Catalog/ViewModel/Product/Breadcrumbs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@

use Magento\Catalog\Helper\Data;
use Magento\Framework\App\Config\ScopeConfigInterface;
use Magento\Framework\App\ObjectManager;
use Magento\Framework\DataObject;
use Magento\Framework\Serialize\Serializer\Json;
use Magento\Framework\View\Element\Block\ArgumentInterface;

/**
Expand All @@ -27,18 +29,26 @@ class Breadcrumbs extends DataObject implements ArgumentInterface
*/
private $scopeConfig;

/**
* @var Json
*/
private $json;

/**
* @param Data $catalogData
* @param ScopeConfigInterface $scopeConfig
* @param Json $json
*/
public function __construct(
Data $catalogData,
ScopeConfigInterface $scopeConfig
ScopeConfigInterface $scopeConfig,
Json $json = null
) {
parent::__construct();

$this->catalogData = $catalogData;
$this->scopeConfig = $scopeConfig;
$this->json = $json ?: ObjectManager::getInstance()->get(Json::class);
}

/**
Expand Down Expand Up @@ -78,4 +88,20 @@ public function getProductName()
? $this->catalogData->getProduct()->getName()
: '';
}

/**
* Returns breadcrumb json.
*
* @return string
*/
public function getJsonConfiguration()
{
return $this->json->serialize([
'breadcrumbs' => [
'categoryUrlSuffix' => $this->getCategoryUrlSuffix(),
'userCategoryPathInUrl' => (int)$this->isCategoryUsedInProductUrl(),
'product' => $this->getProductName()
]
]);
}
}
9 changes: 1 addition & 8 deletions app/code/Magento/Catalog/view/frontend/templates/product/breadcrumbs.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,4 @@
/** @var \Magento\Catalog\ViewModel\Product\Breadcrumbs $viewModel */
$viewModel = $block->getData('viewModel');
?>
<div class="breadcrumbs" data-mage-init='{
"breadcrumbs": {
"categoryUrlSuffix": "<?= $block->escapeHtml($viewModel->getCategoryUrlSuffix()); ?>",
"useCategoryPathInUrl": <?= (int)$viewModel->isCategoryUsedInProductUrl(); ?>,
"product": "<?= $block->escapeHtml($block->escapeJs($viewModel->getProductName())); ?>"
}
}'>
</div>
<div class="breadcrumbs" data-mage-init='<?= /* @escapeNotVerified */ $viewModel->getJsonConfiguration() ?>'></div>