Skip to content

[Backport] Added language translation for message string #15444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2018
Merged

[Backport] Added language translation for message string #15444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2a3b1c
Added language translation for message string
yogeshsuhagiya May 19, 2018
9d01d76
Format the code
yogeshsuhagiya May 19, 2018
8efc333
Added language translation key
yogeshsuhagiya May 20, 2018
002a7c0
Added language translation key
yogeshsuhagiya May 20, 2018
0613e58
Merge pull request #1 from Yogeshks/2.1-develop-PR-port-15333
yogeshks May 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,10 @@ public function execute()
if (empty($result)) {
$result[] = [
'severity' => (string)\Magento\Framework\Notification\MessageInterface::SEVERITY_NOTICE,
'text' => 'You have viewed and resolved all recent system notices. '
. 'Please refresh the web page to clear the notice alert.',
'text' => __(
'You have viewed and resolved all recent system notices. '
. 'Please refresh the web page to clear the notice alert.'
)
];
}
$this->getResponse()->representJson($this->jsonHelper->jsonEncode($result));
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/AdminNotification/i18n/en_US.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,4 @@ Severity,Severity
"Date Added","Date Added"
Message,Message
Actions,Actions
"You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert.","You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert."