Skip to content

Advanced Reporting > Unable to disable without providing Industry val… #15402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Advanced Reporting > Unable to disable without providing Industry val… #15402

wants to merge 1 commit into from

Conversation

@shaandg
Copy link

@shaandg shaandg commented May 21, 2018 •
edited
Loading

Advanced Reporting > Unable to disable without providing Industry value - fixed

Description

Added a condition check while disabling the module, it should not check for other fields to be filled or not.

Fixed Issues (if relevant)

  1. Advanced Reporting > Unable to disable without providing Industry value #15259: Advanced Reporting > Unable to disable without providing Industry value
  2. ...

Manual testing scenarios

  1. Open Store Configuration -> General -> Advanced Reporting
  2. Disable module should now work fine without vertical being selected.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 21, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 26, 2018

Similar Pull Request: #15366

@magento-engcom-team magento-engcom-team mentioned this pull request May 26, 2018
Merged
@shaandg shaandg requested a review from joanhe June 21, 2018 06:06
@orlangur orlangur self-assigned this Jul 11, 2018
@orlangur
Copy link
Contributor

orlangur commented Jul 11, 2018

#15366 seems to be a better option. @shaandg thanks for collaboration!

@orlangur orlangur closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joanhe joanhe Awaiting requested review from joanhe

Assignees

@orlangur orlangur

Labels

Progress: reject

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shaandg @magento-cicd2 @magento-engcom-team @orlangur @shantanu-codilar