Skip to content

6305 - Resolved product custom option title save issue #15357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2018
Merged

6305 - Resolved product custom option title save issue #15357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
474946c
6305 Resolved product custom option title save issue
Madhumalak May 19, 2018
9dd8945
Update DefaultValidator.php
May 20, 2018
641c556
2.2.6-dev-6305 fixed issue on displaying option title in invoice and …
Madhumalak May 24, 2018
3c444ce
2.2.6-dev-6305 changes comment and repushed again for pdf issue
Madhumalak May 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/code/Magento/Catalog/Model/Product/Option/Validator/DefaultValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ protected function isValidOptionTitle($title, $storeId)
if ($storeId > \Magento\Store\Model\Store::DEFAULT_STORE_ID && $title === null) {
return true;
}
if ($this->isEmpty($title)) {

// checking whether title is null and also changed is_empty to is_null
if ($title === null) {
return false;
}

Expand Down
3 changes: 2 additions & 1 deletion app/code/Magento/Catalog/Model/ResourceModel/Product/Option/Value.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,8 @@ protected function _saveValueTitles(AbstractModel $object)
$object->unsetData('title');
}

if ($object->getTitle()) {
/*** Checking whether title is not null ***/
if ($object->getTitle()!= null) {
if ($existInCurrentStore) {
if ($storeId == $object->getStoreId()) {
$where = [
Expand Down
3 changes: 2 additions & 1 deletion app/code/Magento/Sales/Model/Order/Pdf/Items/Invoice/DefaultInvoice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ public function draw()
'feed' => 35,
];

if ($option['value']) {
// Checking whether option value is not null
if ($option['value']!= null) {
if (isset($option['print_value'])) {
$printValue = $option['print_value'];
} else {
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Sales/Model/Order/Pdf/Items/Shipment/DefaultShipment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function draw()
];

// draw options value
if ($option['value']) {
if ($option['value']!= null) {
$printValue = isset(
$option['print_value']
) ? $option['print_value'] : $this->filterManager->stripTags(
Expand Down