Skip to content

#12820 - Wrong annotation in _toOptionArray - magento/framework/Data/… #15336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

#12820 - Wrong annotation in _toOptionArray - magento/framework/Data/… #15336

merged 1 commit into from
May 22, 2018

Conversation

@sanjay-wagento
Copy link
Contributor

@sanjay-wagento sanjay-wagento commented May 19, 2018

Set correct annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Description

Set correct annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Fixed Issues (if relevant)

  1. magento/magento2#<12820>: Wrong annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Manual testing scenarios

  1. Please check request parameter in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this May 21, 2018
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 21, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.2 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels May 21, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 21, 2018

Hi @miguelbalparda, thank you for the review.
ENGCOM-1628 has been created to process this Pull Request

magento-team pushed a commit that referenced this pull request May 22, 2018
ENGCOM-1628: #12820 - Wrong annotation in _toOptionArray - magento/fr…
fcef86e 
…amework/Data/… #15336
@magento-engcom-team magento-engcom-team merged commit e138881 into magento:2.2-develop May 22, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 22, 2018

Hi @sanjay-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

@osrecio osrecio mentioned this pull request May 29, 2018
Merged
4 tasks
This was referenced Jun 1, 2018
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels

Event: dmcdindia Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Milestone

May 2018

Development

Successfully merging this pull request may close these issues.

3 participants

@sanjay-wagento @magento-engcom-team @miguelbalparda