Skip to content

Fix typos in variable names #15294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2018
Merged

Fix typos in variable names #15294

merged 1 commit into from
May 20, 2018

Conversation

@dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented May 17, 2018 •
edited
Loading

Note: Already fixed in 2.3-develop (as part of #13300), no forwardport needed.

Description

Fix typos in variable names

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch added Release Line: 2.2 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels May 17, 2018
@dmytro-ch dmytro-ch requested a review from rogyar May 17, 2018 21:29
@DanielRuf DanielRuf self-requested a review May 18, 2018 05:05
@dmytro-ch dmytro-ch mentioned this pull request May 18, 2018
Merged
4 tasks
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 20, 2018
@magento-engcom-team magento-engcom-team merged commit 4f85f87 into magento:2.2-develop May 20, 2018
magento-engcom-team pushed a commit that referenced this pull request May 20, 2018
ENGCOM-1602: Fix typos in variable names #15294
a3f8bd5
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 20, 2018

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogyar rogyar Awaiting requested review from rogyar

1 more reviewer

@DanielRuf DanielRuf DanielRuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogyar rogyar

@sidolov sidolov

Labels

Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Milestone

May 2018

Development

Successfully merging this pull request may close these issues.

5 participants

@dmytro-ch @magento-engcom-team @DanielRuf @rogyar @sidolov