Skip to content

Fix \Magento\Customer\Model\Customer\NotificationStorage class #15262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2018
Merged

Fix \Magento\Customer\Model\Customer\NotificationStorage class #15262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions app/code/Magento/Customer/Model/Customer/NotificationStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/
namespace Magento\Customer\Model\Customer;

use Magento\Framework\App\ObjectManager;
use Magento\Framework\Cache\FrontendInterface;
use Magento\Framework\Serialize\SerializerInterface;

Expand All @@ -18,21 +19,21 @@ class NotificationStorage
private $cache;

/**
* @param FrontendInterface $cache
*/

/**
* @param FrontendInterface $cache
* @var SerializerInterface
*/
private $serializer;

/**
* NotificationStorage constructor.
* @param FrontendInterface $cache
* @param SerializerInterface $serializer
*/
public function __construct(FrontendInterface $cache)
{
public function __construct(
FrontendInterface $cache,
SerializerInterface $serializer = null
) {
$this->cache = $cache;
$this->serializer = $serializer ?: ObjectManager::getInstance()->get(SerializerInterface::class);
}

/**
Expand All @@ -45,7 +46,7 @@ public function __construct(FrontendInterface $cache)
public function add($notificationType, $customerId)
{
$this->cache->save(
$this->getSerializer()->serialize([
$this->serializer->serialize([
'customer_id' => $customerId,
'notification_type' => $notificationType
]),
Expand Down Expand Up @@ -88,19 +89,4 @@ private function getCacheKey($notificationType, $customerId)
{
return 'notification_' . $notificationType . '_' . $customerId;
}

/**
* Get serializer
*
* @return SerializerInterface
* @deprecated 100.2.0
*/
private function getSerializer()
{
if ($this->serializer === null) {
$this->serializer = \Magento\Framework\App\ObjectManager::getInstance()
->get(SerializerInterface::class);
}
return $this->serializer;
}
}