[backport] fixes for instant purchase module from #15257 #15258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original PR: #15257
The Method
get($type)in/Magento/InstantPurchase/Model/ShippingMethodChoose/DeferredShippingMethodChooserPool.phpthrows an Exception without showing the shipping method $type as it was hardcoded as'chooser'.Allowing
nullfor properties inInstantPurchaseOption.phpas they are null in the constructor by default.Fixing PHPDocs as they refer to wrong Classes or have missing type declarations.
Contribution checklist