Skip to content

Conversation

@mhauri
Copy link

@mhauri mhauri commented May 16, 2018

Description

Original PR: #15257

The Method get($type) in /Magento/InstantPurchase/Model/ShippingMethodChoose/DeferredShippingMethodChooserPool.php throws an Exception without showing the shipping method $type as it was hardcoded as 'chooser'.

Allowing null for properties in InstantPurchaseOption.php as they are null in the constructor by default.

Fixing PHPDocs as they refer to wrong Classes or have missing type declarations.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this May 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1579 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@mhauri thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@mhauri
Copy link
Author

mhauri commented May 17, 2018

Thank you @magento-engcom-team for the invitation 🎉

@mhauri
Copy link
Author

mhauri commented May 17, 2018

@miguelbalparda may you have time to also review the original PR: #15257

@DanielRuf DanielRuf self-requested a review May 17, 2018 21:09
@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants