Skip to content

Conversation

@Jeroenll
Copy link
Member

@Jeroenll Jeroenll commented May 14, 2018

Port of #15089

Description

Unnecessary recalculation of large product list pricing causes huge slowdowns.

Fixed Issues (if relevant)

  1. Unnecessary recalculation of product list pricing causes huge slowdowns #14941: Unnecessary recalculation of product list pricing causes huge slowdowns

Manual testing scenarios

  1. Create a catalog where prices are including tax + prices are shown including tax.
  2. Go to a category page and show 100 products per page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Jeroenll Jeroenll added Release Line: 2.3 port-to-2.3 partners-contribution Pull Request is created by Magento Partner Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 14, 2018
@Jeroenll
Copy link
Member Author

@miguelbalparda, can you also process the port to 2.3-develop?

@VladimirZaets
Copy link
Contributor

Hi, @joachim-havloujian, I took your PR into processing, thank you for collaboration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the method still returns int and bool value because $this->displayCartPricesBoth() returns bool.
Please add bool return type to doc block.

@Jeroenll
Copy link
Member Author

@VladimirZaets DocBlock is updated.

@magento-engcom-team
Copy link
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants