Skip to content

Conversation

@hostep
Copy link
Contributor

@hostep hostep commented May 12, 2018

Description

This is a fix to restore the functionality added by #12441

It is mentioned in the release notes of Magento 2.2.4 that there is supposed to be a new command app:config:status:

You can now use the app:config:status command to check whether configuration propagation is up-to-date. Fix submitted by Juan Alonso in pull request 12441.

But when trying this out on a cleanly installed Magento 2.2.4, that new command doesn't seem to exist.

This is because the line which was added to the di.xml file of the Magento_Deploy module by #12441 was (accidentally?) removed in e6b6c65#diff-2bf3eac66ec091433127117dae63d6a5L34

Just to be sure, the commit which introduced the problem is fixing this issue: #14104 and I verified that restoring this one line in the di.xml file has no influence on issue #14104, so I'm pretty sure that line was accidentally removed (probably by a merge conflict or something like that).

Be aware, if e6b6c65 gets forward ported to Magento 2.3, the fix in this PR will also need to be forward ported.

Fixed Issues (if relevant)

  1. Add command "app:config:status" to check if "app:config:import" needed #12441: Add command "app:config:status" to check if "app:config:import" needed

Manual testing scenarios

  1. Install Magento 2.2.4
  2. Try to execute: bin/magento app:config:status
  3. It won't work, but after applying this PR, it will work again.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-1537 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants