Skip to content

Conversation

@mzeis
Copy link
Contributor

@mzeis mzeis commented May 10, 2018

Original Pull Request

#15032
Fixes Issue #13460, keeps changes from pull request #12284

Description

This fix only sets the value of a group if it doesn't already exist when calling \Magento\Payment\Helper\Data::getPaymentMethodList with parameter $withGroups = true.

Fixed Issues

#13460
#12284

Manual testing scenarios

  1. Call method \Magento\Payment\Helper\Data::getPaymentMethodList
  2. Value of group e.g. "offline" in $labelValues doesn't get set to null because there are already group-related values such as "checkmo".

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 10, 2018
@mzeis mzeis closed this May 10, 2018
@mzeis mzeis deleted the 2.3-develop-PR-port-15032 branch May 10, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants