[Backport] Switch updatecart qty input validators to dynamic #14911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 30, 2018
Contributor
|
Hi @rogyar. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #13462
Description
Currently, the edit cart product input has hardcoded validators which differ from the main PDP page. What is the reasoning for this? This prevents custom qty validators applied on normal PDP from applying when you update said product qty.
updateCart.phtml vs addtocart.phtml
This PR matches both updatecart.phtml and addtocart.phtml qty input validators. Now when you target,
afterGetQuantityValidatorsit will apply to both inputs.Maybe I am mistaken and there is a real reason they did not originally match?
Manual testing scenarios