Skip to content

10058: Tablerate->getCsvFile() fails with non-default PHP upload_tmp_… #14553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dmanners
Copy link
Contributor

@dmanners dmanners commented Apr 5, 2018

…dir(2.3)

Description

Port of #12376

Fixed Issues (if relevant)

  1. Tablerate->getCsvFile() fails with non-default PHP upload_tmp_dir #10058: Tablerate->getCsvFile() fails with non-default PHP upload_tmp_dir

Manual testing scenarios

  1. Make a new directory for uploads, eg mkdir -p /var/lib/php/uploads && chmod 1777 /var/lib/php/uploads
  2. Set PHP upload_tmp_dir to this directory. eg, add upload_tmp_dir = /var/lib/php/uploads to /etc/php.ini
  3. Login to Magento Admin
  4. Go to Stores > Configuration > Sales > Shipping Methods
  5. Select Table Rates, and enable
  6. Click "Import"
  7. Choose a file, click save.

Expected result

Table rates are updated

Actual result

Receive an error, eg The file “/tmp/var/lib/php/uploads/phphEpJe5” doesn’t exist

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants