Skip to content

Removed unused translation for comment tag #14382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2018
Merged

Removed unused translation for comment tag #14382

merged 4 commits into from
Apr 28, 2018

Conversation

yogeshsuhagiya
Copy link
Member

Removed unused translation for <comment> tag, because <comment> not found as a child for the node.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 27, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 27, 2018
@yogeshsuhagiya
Copy link
Member Author

Hello Team,
Any updates on this pull request?

@okorshenko okorshenko modified the milestones: March 2018, April 2018 Apr 16, 2018
@magento-engcom-team magento-engcom-team merged commit 1b1e15e into magento:2.3-develop Apr 28, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 28, 2018
ENGCOM-1102: Removed unused translation for comment tag #14382
00de286
@magento-engcom-team
Copy link
Contributor

Hi @yogeshks. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@rogyar rogyar mentioned this pull request May 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.
6 participants
@yogeshsuhagiya @magento-cicd2 @magento-engcom-team @orlangur @okorshenko @yogeshaureatelabs