-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forwardport] Category\Collection::joinUrlRewrite should use the store set on the collection #14381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 7 commits into
magento:2.3-develop
from
rostyslav-hymon:2.3-develop-PR-port-13716
May 6, 2018
Merged
[Forwardport] Category\Collection::joinUrlRewrite should use the store set on the collection #14381
magento-engcom-team
merged 7 commits into
magento:2.3-develop
from
rostyslav-hymon:2.3-develop-PR-port-13716
May 6, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @rostyslav-hymon, could you add also changes from #14385? |
it shall not pass code review as object under test is mocked and thus it does not test anything
ihor-sviziev
approved these changes
Apr 5, 2018
Contributor
|
Hi @rostyslav-hymon, I added commit from #14385 myself and approved your PR. |
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
May 6, 2018
… use the store set on the collection #14381
magento-engcom-team
pushed a commit
that referenced
this pull request
May 6, 2018
… use the store set on the collection #14381
magento-engcom-team
pushed a commit
that referenced
this pull request
May 6, 2018
… use the store set on the collection #14381
Contributor
|
Hi @rostyslav-hymon. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#13716 + #14385
The problem is that Magento\Catalog\Model\ResourceModel\Category\Collection::joinUrlRewrite always use the store id from the store manager. I think that it should instead use the storeId set on the actual collection.
Description
Now joinUrlRewrite uses directly the storeManager, but if a store is set directly on the collection, it should use the store set, and not the default passed by the store manager.
The method getStoreId(), if not set, already goes on fallback to the store manager and get the default, so it should be safe to directly use getStoreId().
Fixed Issues (if relevant)
Manual testing scenarios
I already provided an automated unit test. There is an code example in the related issue #13704.
It's my first automated test here, so I hope it's ok :)
Contribution checklist