#7816: Customer_account.xml file abused (2.1) #14323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in addiiton to magento#12852 commit 36cac17 - that fix removed the title from being set in the `customer_account.xml` file but the fix seemed to do nothing as the title was always being set in the controller anyway. I've removed from the controller and added to the correct layout file.
Contributor
|
@magento-engcom-team give me new test instance |
Contributor
|
Hi @mzeis unfortunately 2.1-develop branch is not supported at the moment for test instances |
Contributor
|
Hi @okorshenko, ok thanks! |
mzeis
approved these changes
Mar 28, 2018
Contributor
mzeis
left a comment
mzeis
left a comment
There was a problem hiding this comment.
Verified that the English title is correct in the customer account and that the translation (e.g. with a German language pack) works in 2.1.
Contributor
|
Hi @mzeis, thank you for the review. |
Contributor
|
Hi @mikewhitby, thank you for your PR! it has been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The initial problem was that the paypal module was setting the customer dashbaord page to "Billing Agreements", a previous commit of 36cac17 fixed that which I have cherry picked, however there is a related issue - the customer account dashboard title was being set in the controller which was not good, so I've fixed that too.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist