Skip to content

Remove VarienForm as it no longer appears to be included or used. #14266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2018
Merged

Remove VarienForm as it no longer appears to be included or used. #14266

merged 1 commit into from
Mar 25, 2018

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Mar 22, 2018 •
edited
Loading

Description

This code no longer appears to be included from anywhere within the core,
I see resolvers that mention the directory but again no direct calls that I can see:

  • setup/src/Magento/Setup/Module/I18n/Dictionary/Options/Resolver.php
  • setup/src/Magento/Setup/Test/Unit/Module/I18n/Dictionary/Options/ResolverTest.php

Manual testing scenarios

  1. Ensure there isn't any use of VarienForm, RegionUpdater and ZipUpdater from form.js

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev ihor-sviziev self-assigned this Mar 22, 2018
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 23, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 23, 2018

Hi @ihor-sviziev, thank you for the review.
ENGCOM-1034 has been created to process this Pull Request

@sidolov sidolov requested a review from VladimirZaets March 23, 2018 10:06
@magento-engcom-team magento-engcom-team merged commit 25c1f87 into magento:2.3-develop Mar 25, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 25, 2018
ENGCOM-1034: Remove VarienForm as it no longer appears to be included…
dc7b241 
… or used. #14266
@jonathanKingston jonathanKingston deleted the 2.3-develop_remove-varienForm branch March 26, 2018 23:44
Shubham0492 pushed a commit to Shubham0492/magento2 that referenced this pull request Oct 14, 2018
fixed magento#14266 issue
2022b0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels

Progress: accept Release Line: 2.3

Projects

None yet

Milestone

March 2018

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathanKingston @magento-engcom-team @ihor-sviziev @VladimirZaets