Fix for broken navigation menu on IE11 #14230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The navigation without the "display: inline-block" sometimes gets broken on Internet Explorer 11. This happens after some refreshes of the page, both on Luma and Blank theme.
…n-ie11 Update navigation less with display: inline-block
Contributor
|
@cstergianos thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
This was referenced Mar 26, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 26, 2018
magento-engcom-team
added a commit
that referenced
this pull request
Mar 27, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 27, 2018
magento-engcom-team
added a commit
that referenced
this pull request
Mar 27, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 27, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 27, 2018
Accepted Public Pull Requests: - #14383: [Forwardport] FR#7428 - Multiline fields in forms have no visible label (by @rostyslav-hymon) - #14387: [Forwardport] Format code (by @rostyslav-hymon) - #14345: Fix OptionsRepository API test to add option by attribute_id (by @bcerban) - #14329: Port: Fix for broken navigation menu on IE11 #14230 (by @sergiy-v) - #14343: Checkout module: Removing deprecated Message Manager method calls (by @Loxzibit) - #14341: magento/magento2: Updating deprecated message manager methods (by @JamelleG) Fixed GitHub Issues: - #7428: Multiline fields in forms have no visible label (reported by @navarr) has been fixed in #14383 by @rostyslav-hymon in 2.3-develop branch Related commits: 1. 8d52421 - #5580: Cannot add multiple options to configurable product via REST API (reported by @svines) has been fixed in #14345 by @bcerban in 2.3-develop branch Related commits: 1. 966d8bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The navigation without the "display: inline-block" sometimes gets broken on Internet Explorer 11. This happens after some refreshes of the page, both on Luma and Blank theme. The problem is that the A element has no display: inline-block or block but also has padding. IE11 understands that differently sometimes without giving any of the inline block properties to the element like width or padding.
Manual testing scenarios
Corresponding videos & screenshots
BLANK THEME VIDEO
BLANK THEME SCREENSHOT
LUMA THEME VIDEO
LUMA THEME SCREENSHOT
Contribution checklist