Skip to content

Improve Customer GraphQL Model code quality #14158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Improve Customer GraphQL Model code quality #14158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/code/Magento/CustomerGraphQl/Model/Resolver/Customer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@

namespace Magento\CustomerGraphQl\Model\Resolver;

use Magento\Authorization\Model\UserContextInterface;
use Magento\CustomerGraphQl\Model\Resolver\Customer\CustomerDataProvider;
use Magento\Framework\Exception\NoSuchEntityException;
use Magento\Framework\GraphQl\Exception\GraphQlAuthorizationException;
use Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException;
use Magento\GraphQl\Model\ResolverInterface;
use Magento\Framework\GraphQl\Exception\GraphQlInputException;
use Magento\GraphQl\Model\ResolverContextInterface;

/**
Expand All @@ -24,10 +25,10 @@ class Customer implements ResolverInterface
private $customerResolver;

/**
* @param \Magento\CustomerGraphQl\Model\Resolver\Customer\CustomerDataProvider $customerResolver
* @param CustomerDataProvider $customerResolver
*/
public function __construct(
\Magento\CustomerGraphQl\Model\Resolver\Customer\CustomerDataProvider $customerResolver
CustomerDataProvider $customerResolver
) {
$this->customerResolver = $customerResolver;
}
Expand All @@ -37,7 +38,7 @@ public function __construct(
*/
public function resolve(array $args, ResolverContextInterface $context)
{
if ((!$context->getUserId()) || $context->getUserType() == 4) {
if ((!$context->getUserId()) || $context->getUserType() == UserContextInterface::USER_TYPE_GUEST) {
throw new GraphQlAuthorizationException(
__(
'Current customer does not have access to the resource "%1"',
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/CustomerGraphQl/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"require": {
"php": "7.0.2|7.0.4|~7.0.6|~7.1.0",
"magento/module-customer": "100.2.*",
"magento/module-authorization": "100.3.*",
"magento/module-graph-ql": "100.0.*",
"magento/framework": "100.3.*"
},
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/CustomerGraphQl/etc/module.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<module name="Magento_CustomerGraphQl" >
<sequence>
<module name="Magento_Customer"/>
<module name="Magento_Authorization"/>
<module name="Magento_GraphQl"/>
</sequence>
</module>
Expand Down