Skip to content

Conversation

@orlangur
Copy link
Contributor

@orlangur orlangur commented Mar 13, 2018

Description

Obsolete tools removed:

  1. dev/tools/Magento/Tools/Layout is a set of XSLT processors used within Magento 2 development prior to 2.0 GA. Can be useful only as a migration tool but those are consolidated in separate repo.
  2. dev/tools/Magento/Tools/StaticReview/pre-commit pre-commit hook based on sjparkinson/static-review implemented by me, never really liked it anyway as it processed files one-by-one, just tried to reuse some existing library instead of a custom bash script
  3. dev/tools/Magento/Tools/psr/phpcs_precommit_hook.sh even older pre-commit hook, not worth fixing, better use PHPCS in IDE directly or via phpro/grumphp

Fixed Issues (if relevant)

Only "Package sjparkinson/static-review is abandoned, you should avoid using it. Use phpro/grumphp instead." composer warning eliminated.
#14138

Manual testing scenarios

Nothing to test manually, it is enough to run automated tests.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-898 has been created to process this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants