Removed unnecessary protected member variables.

[yogeshsuhagiya]

Hello,

Description

Removed unnecessary protected member variables of Image class.
The variable $imageHelper, $product and $attributes are not in use.
Above three variable doesn't contain any values. Also verified it on category, product and cart page.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[mzeis]

Hi @yogeshks,

thanks for your contribution! Unfortunately, removing protected properties is not allowed by the backwards incompatible development guide. I see that you are saying the properties aren't used - I can check on that. We have to be careful though to not break any behaviour in third party code if this should go into 2.2-develop.

What you could do according to the guide is to tag the properties as @deprecated in 2.2-develop and create another PR for 2.3-develop, removing them.

[yogeshsuhagiya]

Hi @mzeis

Thank you so much for your guidance, I've restored protected properties and marked them as @deprecated as per your suggestion.

[orlangur]

@mzeis what's the point in such comments? They should be added or properties should be removed all at once with some automated tooling.

[mzeis]

Hi @yogeshks, I updated your PR:

• Added an explanation why the property is deprecated
• Removed "deprecated since" information (this will be added automatically for a new release)
• Removed added whitespace

You don't need to create a PR for 2.3-develop as the properties will be removed automatically.

[magento-engcom-team]

Hi @mzeis, thank you for the review.
ENGCOM-847 has been created to process this Pull Request

[magento-engcom-team]

@yogeshks thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[mzeis]

Hi @yogeshks, thanks for your PR! It has been merged into 2.2-develop.