Skip to content

Conversation

@Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Mar 9, 2018

fixed layout attribute value from admin-2columns-left to admin-1column, because it has no sidebar.

Description

changed layout attribute value from admin-2columns-left to admin-1column, because it has no sidebar.
version 2.0 was with sidebar and has correct admin-2columns-left
version 2.2 and 2.3 have also correct layout admin-1column

Manual testing scenarios

  1. Magento version 2.1.x
  2. Admin -> MARKETING -> Catalog Price Rule -> Add New Rule
  3. New Catalog Price Rule edit page has layout page-layout-admin-2columns-left, but should be 1column

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

changed layout attribute value from admin-2columns-left to admin-1column, because it has no sidebar.
@Karlasa Karlasa added Admin Panel Release Line: 2.1 Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Mar 9, 2018
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 9, 2018
@magento-engcom-team magento-engcom-team merged commit 717ab14 into magento:2.1-develop Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants