Skip to content

Refactor: Unit test naming #14006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2018
Merged

Refactor: Unit test naming #14006

merged 2 commits into from
Mar 9, 2018

Conversation

@schmengler
Copy link
Contributor

@schmengler schmengler commented Mar 8, 2018

Description

Minor refactoring to make category and product unit tests for custom attributes clearer.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@schmengler schmengler requested a review from nmalevanec March 8, 2018 09:12
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 8, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@schmengler schmengler changed the base branch from 2.2-develop to 2.3-develop March 8, 2018 09:12
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 8, 2018
@sidolov
Copy link
Contributor

sidolov commented Mar 8, 2018

Fixed static fails

@magento-engcom-team magento-engcom-team merged commit 0eb0482 into magento:2.3-develop Mar 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 9, 2018
ENGCOM-807: Refactor: Unit test naming #14006
03e4e3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nmalevanec nmalevanec nmalevanec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sidolov sidolov

Labels

Progress: accept Release Line: 2.3

Projects

None yet

Milestone

March 2018

Development

Successfully merging this pull request may close these issues.

5 participants

@schmengler @magento-cicd2 @sidolov @nmalevanec @magento-engcom-team